Conversation
|
jacomago
force-pushed
the
remove-ignorable-error-logs
branch
3 times, most recently
from
acc50f1 to
6532f43
Compare
|
jacomago
requested review from
anderslindho,
domonkos-ess,
georgweiss,
imretoth-ess,
jeonghanlee,
shroffk,
simon-ess and
tynanford
|
simon-ess
reviewed
Feb 11, 2026
| MetricsService.generateAllMultiValueMaps(properties); | ||
|
|
||
| assertEquals(1, allMaps.size()); | ||
| assertEquals(0, allMaps.size()); |
Contributor
Author
There was a problem hiding this comment.
Don't know why I had that before, but since I updated MetricsService to now return an empty map instead of a list with an emtpymap, now this should be 0.
anderslindho
approved these changes
Feb 11, 2026
Contributor
anderslindho
left a comment
anderslindho
left a comment
There was a problem hiding this comment.
You have to put more info in your commit messages: it doesn't make sense that I have to read and understand the code in order to understand the commit message and then, following that, what you're wanting to accomplish and why.
Reduces the scope of the test so less beans are loaded in the test.
Reduce the number of tests where the aa processor is enabled this gets rid of error logs saying there is no connection to the archiver in unrelated tests
This tries to reduce the beans run per tests, to limit scope of the test and stop bad error messages from other not correctly mocked or wired beans
As it then will produce error messages infecting the logs This happens when the metricssserviceIT is run with other integration tests, as the schedule to fetch metrics from elastic persists even though the indexes were deleted.
jacomago
force-pushed
the
remove-ignorable-error-logs
branch
from
174fb21 to
bb0a15f
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.